Adds Context to contain settings, https resolvers and signers. #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates unit test to use this.
…write a duplicate manifest.json file.
…rts. adds unit test for from_stream and c2p2.created.
add_ingredient_from_stream always set position to zero inside read methods
added Builder::from_context() builder.with_json()
Add ContentCredential.open_stream()
…a settings instance
Reader::new and reader.with_stream added.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
==========================================
- Coverage 75.30% 75.17% -0.13%
==========================================
Files 166 169 +3
Lines 37257 37272 +15
==========================================
- Hits 28055 28018 -37
- Misses 9202 9254 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1631 will not alter performanceComparing Summary
Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Context struct that contains settings, https resolvers and signers.
This is a work in progress but hopefully the right direction